Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Nov 3, 2022

@vstinner
Copy link
Member Author

vstinner commented Nov 3, 2022

cc @mattip

@mattip
Copy link
Contributor

mattip commented Nov 3, 2022

Thanks, this makes the code compatible with PyPy which does not have a tuple.__itemsize__

@vstinner vstinner changed the title gh:97616: test_list_resize_overflow() uses sys.maxsize gh-97616: test_list_resize_overflow() uses sys.maxsize Nov 3, 2022
@vstinner
Copy link
Member Author

vstinner commented Nov 3, 2022

I removed the fix to test manually that the modified test still triggers the crash:

test_list_resize_overflow (test.test_list.ListTest.test_list_resize_overflow) ... Fatal Python error: Segmentation fault

Current thread 0x00007f9d3fe11740 (most recent call first):
  File "/home/vstinner/python/main/Lib/test/test_list.py", line 110 in test_list_resize_overflow

Yep, it does still crash :-)

@vstinner vstinner merged commit b8a9f13 into python:main Nov 3, 2022
@vstinner vstinner deleted the test_list_resize branch November 3, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants