-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
Docs: add named to the note describing the sqlite3.paramstyle attribute
#99078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation for `sqlite3.paramstyle` states that only `qmark` and `numeric` styles are supported for parameter placeholders but, according to the SQLite documentation, the `named` style is also supported. See the following links for more details: - https://docs.python.org/3/library/sqlite3.html#sqlite3.paramstyle - https://peps.python.org/pep-0249/#paramstyle - https://www.sqlite.org/lang_expr.html#parameters A simple example confirms that this is supported: ```pycon >>> import sqlite3 >>> con = sqlite3.connect(":memory:") >>> cur = con.execute("CREATE TEMPORARY TABLE t (name TEXT)") >>> cur.execute("INSERT INTO t (name) VALUES ('Bob'), ('Cat'), ('Joe')") <sqlite3.Cursor object at 0x7fcbe373b940> >>> cur.execute("SELECT * FROM t WHERE name = :name", {"name": "Cat"}) <sqlite3.Cursor object at 0x7fcbe373b940> >>> print(cur.fetchone()[0]) Cat ```
ebd50d6 to
8019ca3
Compare
erlend-aasland
approved these changes
Nov 3, 2022
Contributor
erlend-aasland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks; lgtm!
named paramstyle in sqlite3.named to the note describing the sqlite3.paramstyle attribute
Contributor
|
Thanks @ngnpope for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 3, 2022
…r docs (pythonGH-99078) (cherry picked from commit 016c7d3) Co-authored-by: Nick Pope <nick@nickpope.me.uk>
|
GH-99081 is a backport of this pull request to the 3.11 branch. |
|
GH-99082 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 3, 2022
…r docs (pythonGH-99078) (cherry picked from commit 016c7d3) Co-authored-by: Nick Pope <nick@nickpope.me.uk>
Contributor
Author
|
Thanks! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
sqlite3.paramstylestates that onlyqmarkandnumericstyles are supported for parameter placeholders but, according to the SQLite documentation, thenamedstyle is also supported.See the following links for more details:
A simple example confirms that this is supported: