From 1ffe37e6430d79fbf7d004d4a5f5feac56c211d5 Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Sat, 20 Oct 2018 07:58:16 -0700 Subject: [PATCH 1/2] bpo-34576 - Fix the formatting for security considerations in http.server.rst --- Doc/library/http.server.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Doc/library/http.server.rst b/Doc/library/http.server.rst index 0b93c62288b189..a643f31793da9b 100644 --- a/Doc/library/http.server.rst +++ b/Doc/library/http.server.rst @@ -16,12 +16,12 @@ This module defines classes for implementing HTTP servers (Web servers). -Security Considerations ------------------------ -http.server is meant for demo purposes and does not implement the stringent -security checks needed of real HTTP server. We do not recommend -using this module directly in production. +.. warning:: + + http.server is meant for demo purposes and does not implement the stringent + security checks needed of a real HTTP server. We do not recommend + using this module directly in production. One class, :class:`HTTPServer`, is a :class:`socketserver.TCPServer` subclass. From a817a6f2b14d4cba4f3d996571bad6f45bc2e7f0 Mon Sep 17 00:00:00 2001 From: Senthil Kumaran Date: Sat, 20 Oct 2018 11:13:01 -0700 Subject: [PATCH 2/2] Address review comment. --- Doc/library/http.server.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/library/http.server.rst b/Doc/library/http.server.rst index a643f31793da9b..45bb529f8c07fa 100644 --- a/Doc/library/http.server.rst +++ b/Doc/library/http.server.rst @@ -19,8 +19,8 @@ This module defines classes for implementing HTTP servers (Web servers). .. warning:: - http.server is meant for demo purposes and does not implement the stringent - security checks needed of a real HTTP server. We do not recommend + :mod:`http.server` is meant for demo purposes and does not implement the + stringent security checks needed of a real HTTP server. We do not recommend using this module directly in production.