Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
bpo-35078:Allow customization of CSS class name of a month in calendar module #10137
Tests could be added for the new change at
self.assertIn('class="month"', local_month) cal.cssclass_month_head = "text-center month" local_month = cal.formatmonthname(2010, 10) self.assertIn('class="text-center month"', local_month)
A NEWS entry might help with the change.
Thanks for the PR :)
tirkarthi left a comment •
I would suggest adding the actual change done to the NEWS entry in addition to the current text like
The month's head CSS class in :class:`calendar.LocaleHTMLCalendar` is now customizable with attribute ``cssclass_month_head``.
It's more of a personal opinion and would leave it to the reviewer to consider the wording. Other than that LGTM. Thanks for your contribution :)
The code looks good to me. There's no additional test for
However there's no test for the changed method
Furthermore the NEWS entry is misleading (and as Serhiy noted on bpo: "We don't usually do pure refactoring changes"). I'd use something like: "Refactor
If you could add a test for