New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] bpo-21622 ctypes.util find_library walk LD_LIBRARY_PATH (GH-10453) #10455

Closed
wants to merge 2 commits into
base: 2.7
from

Conversation

Projects
None yet
3 participants
@jcastillo2nd
Copy link

jcastillo2nd commented Nov 10, 2018

Originally, issue was open for case where SONAME wasn't part of binary.

Later updates to the posix search case did include LD_LIBRARY_PATH but were not backported. Additionally, these had reliance on gcc and ldconfig behavior that breaks in some cases. e.g. musl on alpine builds

This provides a find method that walks the LD_LIBRARY_PATH, checks for ELF bytes, and returns the name when found or None, matching the other behavior.

This runs after all prior cases fail, does not rely on SONAME entry, gcc or ldconfig -p behavior.

https://bugs.python.org/issue21622

jcastillo2nd added some commits Nov 10, 2018

Issue #21622 Walk LD_LIBRARY_PATH for library
FIXES bpo-21622 for 2.7
@the-knights-who-say-ni

This comment has been minimized.

Copy link

the-knights-who-say-ni commented Nov 10, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@jcastillo2nd

This comment has been minimized.

Copy link
Author

jcastillo2nd commented Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment