-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
Fix c-analyzer for GCC: ignore LANG env var #106173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The c-analyzer doesn't support GCC localized messages, so just unset the LANG environment variable.
|
Example with LANG=fr_FR.UTF-8 on Fedora 38: |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry @vstinner, I had trouble checking out the |
|
GH-106177 is a backport of this pull request to the 3.11 branch. |
The c-analyzer doesn't support GCC localized messages, so just unset the LANG environment variable. (cherry picked from commit 1f74b9e) Co-authored-by: Victor Stinner <vstinner@python.org>
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
GH-106178 is a backport of this pull request to the 3.12 branch. |
The c-analyzer doesn't support GCC localized messages, so just unset the LANG environment variable. (cherry picked from commit 1f74b9e) Co-authored-by: Victor Stinner <vstinner@python.org>
|
I get a similar error on macOS: Maybe the (extremely long) message printed upon any failure ought to include the fact that it requires GCC? Or maybe it should print something simpler, like "GCC Required" when it detects a different compiler is being used? Since I only have easy access to macOS and I occasionally need to silence this tool, it's rather annoying to have to wait for a full CI cycle to validate that my guess at fixing it works. (CC: @ericsnowcurrently, but don't interrupt your vacation for this!) |
|
(Also, @vstinner, thanks for the fix!) |
|
@gvanrossum, regarding the GCC requirement, if you have a minute would you mind opening an issue for this (and CC me)? I'll probably lose track of it otherwise. Thanks! (I'm in a little village in the French Alps!) |
The c-analyzer doesn't support GCC localized messages, so just unset the LANG environment variable.