Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… #10638

Merged
merged 6 commits into from Sep 11, 2019

Conversation

@PierreQuentel
Copy link
Contributor

commented Nov 21, 2018

… no content-length header

https://bugs.python.org/issue20504

Pierre Quentel
Pierre Quentel added 2 commits Nov 21, 2018
Pierre Quentel
}
fields = cgi.FieldStorage(fp, environ=env)

assert len(fields["my-arg"].file.read()) == 5

This comment has been minimized.

Copy link
@ZackerySpytz

ZackerySpytz Dec 23, 2018

Contributor

unittest.TestCase methods (like assertEqual()) should be used instead of raw asserts.

This comment has been minimized.

Copy link
@PierreQuentel

PierreQuentel Jan 3, 2019

Author Contributor

Thanks, done in commit d67919b

@benjaminp benjaminp merged commit 2d7caca into python:master Sep 11, 2019

5 checks passed

Azure Pipelines PR #20190104.10 succeeded
Details
bedevere/issue-number Issue number 20504 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

@benjaminp: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @PierreQuentel for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (
pythonGH-10638)

* bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header

* Add Misc/NEWS.d/next file.

* Add rst formatting for NEWS.d/next file

* Reaplce assert by self.assertEqual
(cherry picked from commit 2d7caca)

Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15919 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (
pythonGH-10638)

* bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header

* Add Misc/NEWS.d/next file.

* Add rst formatting for NEWS.d/next file

* Reaplce assert by self.assertEqual
(cherry picked from commit 2d7caca)

Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15920 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (
GH-10638)

* bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header

* Add Misc/NEWS.d/next file.

* Add rst formatting for NEWS.d/next file

* Reaplce assert by self.assertEqual
(cherry picked from commit 2d7caca)

Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
miss-islington added a commit that referenced this pull request Sep 11, 2019
bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (
GH-10638)

* bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header

* Add Misc/NEWS.d/next file.

* Add rst formatting for NEWS.d/next file

* Reaplce assert by self.assertEqual
(cherry picked from commit 2d7caca)

Co-authored-by: Pierre Quentel <pierre.quentel@gmail.com>
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (
python#10638)

* bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header

* Add Misc/NEWS.d/next file.

* Add rst formatting for NEWS.d/next file

* Reaplce assert by self.assertEqual
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has… (
python#10638)

* bpo-20504 : in cgi.py, fix bug when a multipart/form-data request has no content-length header

* Add Misc/NEWS.d/next file.

* Add rst formatting for NEWS.d/next file

* Reaplce assert by self.assertEqual
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.