Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
bpo-35148: fix resetting codepage in activate.bat #10696
The current version of the Windows
E.g. on a German Windows 10 version (or the bug reporter's Swiss version) the output of
Unlike the US version, the statement ends with a period, unexpected by the activation script, leading to an unsuccessful attempt to reset the codepage after venv installation. While the venv is set up correctly, the codepage is not reset. In addition a user-visible error message appears, confusing users and giving the doubt whether venv actually worked:
(English: "wrong parameter format")
The fix leaves the original approach in place, but deletes any periods from the CP number string, if they exist, which means it simply cleans up the CP string. This should have minimal side effects.
Hello, and thanks for your contribution!
I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).
Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.
You can check yourself to see if the CLA has been received.
Thanks again for your contribution, we look forward to reviewing it!
Dear reviewers, this is another attempt to draw anybody's attention to this fix. For non-US Windows versions like German and Swiss the linked bug is quite annoying and confusing users. If at all possible could anybody review this trivial patch?
I s/o knows what I can do to bring just a little bit of attention to this patch to get it merged, please let me know.
@Acconut You're welcome.
It's sad, that there does not seem to be a way to raise this annoyance for non-US users to the mainly US-based core developer group. I gave up on re-requesting a review.
If anybody has a suggestion, please let me know.
Just double-checked with 3.7.3. Ugh...
This issue is resolved (#8321). Sorry it was handled badly. In addition to the accepted PR and this PR, there was also #10295. The latter was merged but subsequently reverted because it relied on the virtual environment having a "python.exe" executable, but sometimes we only have the debug build, "python_d.exe". Maybe Vinay was waiting for that problem to be addressed.