Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) #10718

Merged
merged 1 commit into from Nov 26, 2018

Conversation

@vstinner
Copy link
Member

commented Nov 26, 2018

Fix str.format(), float.format() and complex.format() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)

https://bugs.python.org/issue33954

bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623)
Fix str.format(), float.__format__() and complex.__format__() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)

@vstinner vstinner merged commit 6f5fa1b into python:3.7 Nov 26, 2018

5 of 6 checks passed

Azure Pipelines PR #20181126.18 failed
Details
bedevere/issue-number Issue number 33954 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Nov 26, 2018

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Nov 26, 2018

Sorry, @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6f5fa1b4be735159e964906ab608dc467476e47c 3.6

@vstinner vstinner deleted the vstinner:insert_thousands37 branch Nov 26, 2018

@bedevere-bot

This comment has been minimized.

Copy link

commented Nov 26, 2018

GH-10720 is a backport of this pull request to the 3.6 branch.

vstinner added a commit to vstinner/cpython that referenced this pull request Nov 26, 2018
bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (pythonGH-10623) (p…
…ythonGH-10718)

Fix str.format(), float.__format__() and complex.__format__() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)
(cherry picked from commit 6f5fa1b)
vstinner added a commit that referenced this pull request Nov 26, 2018
bpo-33954: Fix _PyUnicode_InsertThousandsGrouping() (GH-10623) (GH-10718
) (GH-10720)

Fix str.format(), float.__format__() and complex.__format__() methods
for non-ASCII decimal point when using the "n" formatter.

Rewrite _PyUnicode_InsertThousandsGrouping(): it now requires
a _PyUnicodeWriter object for the buffer and a Python str object
for digits.

(cherry picked from commit 59423e3)
(cherry picked from commit 6f5fa1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.