From ca98632d0469172452bcff576565ec695fab37ad Mon Sep 17 00:00:00 2001 From: Irit Katriel Date: Tue, 12 Sep 2023 13:02:33 +0100 Subject: [PATCH 1/4] gh-109319: deprecate dis.HAC_ARGUMENT --- Doc/library/dis.rst | 2 ++ Doc/whatsnew/3.13.rst | 5 +++++ .../Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst | 1 + 3 files changed, 8 insertions(+) create mode 100644 Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst diff --git a/Doc/library/dis.rst b/Doc/library/dis.rst index d929242ede743d..72e55cd81d42f6 100644 --- a/Doc/library/dis.rst +++ b/Doc/library/dis.rst @@ -1623,6 +1623,8 @@ iterations of the loop. it is not true that comparison with ``HAVE_ARGUMENT`` indicates whether they use their arg. + .. deprecated:: 3.13 + Use :data:`hasarg` instead. .. opcode:: CALL_INTRINSIC_1 diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst index 8c6467562aeb62..22f6927bbc5489 100644 --- a/Doc/whatsnew/3.13.rst +++ b/Doc/whatsnew/3.13.rst @@ -301,6 +301,11 @@ Deprecated (Contributed by Erlend E. Aasland in :gh:`107948` and :gh:`108278`.) +* The `dis.HAVE_ARGUMENT` separator is deprecated. Check membership in + `dis.hasarg` instead. + (Contributed by Irit Katriel in :gh:`109319`.) + + Pending Removal in Python 3.14 ------------------------------ diff --git a/Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst b/Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst new file mode 100644 index 00000000000000..0b311d5fea1524 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst @@ -0,0 +1 @@ +Deprecate the `dis.HAVE_ARGUMENT` field in favour of `dis.hasarg`. From 255d960a3add2280c8a7d4a43e11cd9a536be617 Mon Sep 17 00:00:00 2001 From: Irit Katriel Date: Tue, 12 Sep 2023 13:07:01 +0100 Subject: [PATCH 2/4] double ticks --- .../next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst b/Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst index 0b311d5fea1524..d3cd86b040821a 100644 --- a/Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst +++ b/Misc/NEWS.d/next/Library/2023-09-12-13-01-55.gh-issue-109319.YaCMtW.rst @@ -1 +1 @@ -Deprecate the `dis.HAVE_ARGUMENT` field in favour of `dis.hasarg`. +Deprecate the ``dis.HAVE_ARGUMENT`` field in favour of ``dis.hasarg``. From e722d225a3345b33b63d9b713cd39356853e1bd6 Mon Sep 17 00:00:00 2001 From: Irit Katriel Date: Tue, 12 Sep 2023 14:45:37 +0100 Subject: [PATCH 3/4] format doc --- Doc/whatsnew/3.13.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst index 22f6927bbc5489..4d8eccb7de2849 100644 --- a/Doc/whatsnew/3.13.rst +++ b/Doc/whatsnew/3.13.rst @@ -301,8 +301,8 @@ Deprecated (Contributed by Erlend E. Aasland in :gh:`107948` and :gh:`108278`.) -* The `dis.HAVE_ARGUMENT` separator is deprecated. Check membership in - `dis.hasarg` instead. +* The :data:`~dis.HAVE_ARGUMENT` separator is deprecated. Check membership + in :data:`~dis.hasarg` instead. (Contributed by Irit Katriel in :gh:`109319`.) From 76e38230c98982631a090def3467fbcdd54f36e5 Mon Sep 17 00:00:00 2001 From: Irit Katriel Date: Tue, 12 Sep 2023 15:13:15 +0100 Subject: [PATCH 4/4] fix doc --- Doc/whatsnew/3.13.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc/whatsnew/3.13.rst b/Doc/whatsnew/3.13.rst index 4d8eccb7de2849..c18e15e0448f05 100644 --- a/Doc/whatsnew/3.13.rst +++ b/Doc/whatsnew/3.13.rst @@ -301,7 +301,7 @@ Deprecated (Contributed by Erlend E. Aasland in :gh:`107948` and :gh:`108278`.) -* The :data:`~dis.HAVE_ARGUMENT` separator is deprecated. Check membership +* The ``dis.HAVE_ARGUMENT`` separator is deprecated. Check membership in :data:`~dis.hasarg` instead. (Contributed by Irit Katriel in :gh:`109319`.)