remove redundant call to attach_loop #110847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
|
Looks backportable to 3.11 and 3.12 |
gvanrossum
added
needs backport to 3.11
|
Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @graingert for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Sorry, @graingert and @gvanrossum, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 14, 2023
(cherry picked from commit 5965891) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
|
GH-110867 is a backport of this pull request to the 3.12 branch. |
|
Let’s forget about 3.11. |
|
GH-110870 is a backport of this pull request to the 3.11 branch. |
gvanrossum
pushed a commit
that referenced
this pull request
Oct 14, 2023
gvanrossum
pushed a commit
that referenced
this pull request
Oct 15, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PidfdChildWatcher and ThreadedChildWatcher both define a noop attach_loop method so the call is redundant
I didn't think this PR requires an issue