Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.6] bpo-34279: regrtest consider that skipped tests are ran (GH-11132) #11156

Closed

Conversation

Projects
None yet
5 participants
@miss-islington
Copy link

commented Dec 14, 2018

bpo-34279, bpo-35412: support.run_unittest() no longer raises
TestDidNotRun if a test result contains skipped tests. The
exception is now only raised if no test have been run and no test
have been skipped.
(cherry picked from commit 3a8f4fe)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue34279

bpo-34279: regrtest consider that skipped tests are ran (GH-11132)
bpo-34279, bpo-35412: support.run_unittest() no longer raises
TestDidNotRun if a test result contains skipped tests. The
exception is now only raised if no test have been run and no test
have been skipped.
(cherry picked from commit 3a8f4fe)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@vstinner
Copy link
Member

left a comment

LGTM, good bot.

@miss-islington

This comment has been minimized.

Copy link
Author

commented Dec 14, 2018

@vstinner: Status check is done, and it's a success .

@vstinner

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

@ned-deily: Is the 3.6 branch currently blocked?

@ned-deily

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

Yes, as I announced earlier. The 3.6 branch is now in security-fix mode with the exception of any 3.6.8 release blocker regressions.

https://discuss.python.org/t/3-7-2rc1-and-3-6-8rc1-cutoffs-ahead-last-3-6-x-bugfix-release/510/3
https://mail.python.org/pipermail/python-committers/2018-December/006474.html

@vstinner

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

@ned-deily it's hard for me to accept that I have to "abandon" (bugfixes in) 3.6 :-( I love this version! It's the version used for Python 3 in RHEL 8 beta!

@vstinner vstinner closed this Dec 14, 2018

@miss-islington miss-islington deleted the miss-islington:backport-3a8f4fe-3.6 branch Dec 14, 2018

@ned-deily

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

Yeah, 3.6 has been a big success, thanks to everyone’s hard work including yours. But it’s been in bug fix mode longer than any other 3.x release. Now we can focus on 3.7 bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.