gh-115026: AC should generate code that checks for errors of PyBuffer_FillInfo
#115027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yBuffer_FillInfo`
sobolevn
requested review from
berkerpeksag and
erlend-aasland
as code owners
serhiy-storchaka
approved these changes
Feb 5, 2024
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
This is not a real bug, but I do not mind to change the generated code, because it can provoke a bug if someone look at the Argument Clinic generated code and copy it with modifications.
encukou
approved these changes
Feb 5, 2024
erlend-aasland
approved these changes
Feb 5, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also changed
0to bePyBUF_SIMPLE, because it is more canonical.PyBuffer_FillInfoin generated code #115026