New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35717: Fix KeyError exception raised when using enums and compile #11523

Open
wants to merge 3 commits into
base: master
from

Conversation

@remilapeyre
Copy link
Contributor

remilapeyre commented Jan 11, 2019

@remilapeyre remilapeyre changed the title bpo-17467: Fix KeyError exception raised when using enums and compile bpo-35717: Fix KeyError exception raised when using enums and compile Jan 11, 2019

Show resolved Hide resolved Lib/test/test_enum.py Outdated
Show resolved Hide resolved Lib/test/test_enum.py Outdated
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 11, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre

This comment has been minimized.

Copy link
Contributor

remilapeyre commented Jan 11, 2019

I have made the requested changes; please review again

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 11, 2019

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@ethanfurman
Copy link
Member

ethanfurman left a comment

Looks good.

Now add yourself to Misc/ACKS. :)

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 11, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre

This comment has been minimized.

Copy link
Contributor

remilapeyre commented Jan 11, 2019

Thanks @ethanfurman, I have made the requested changes; please review again.

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 11, 2019

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment