From 30e1781400c17bd49ea399a2e6e55cbd34c19f9d Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Sun, 3 Mar 2024 12:15:23 -0500 Subject: [PATCH 1/2] gh-116265: Remove obsolete sentence. Remove sentence in Tools/c-analyzer/README referring to deleted ignore-globals.txt. --- Tools/c-analyzer/README | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Tools/c-analyzer/README b/Tools/c-analyzer/README index 86bf1e77e0bfea..195bac8f2b6eb6 100644 --- a/Tools/c-analyzer/README +++ b/Tools/c-analyzer/README @@ -11,9 +11,8 @@ falls into one of several categories: * module state * Python runtime state -The ignored-globals.txt file is organized similarly. Of the different -categories, the last two are problematic and generally should not exist -in the codebase. +Of the different categories, the last two are problematic and +generally should not exist in the codebase. Globals that hold module state (i.e. in Modules/*.c) cause problems when multiple interpreters are in use. For more info, see PEP 3121, From 18dcdf16213b80892c22ebf75aa47df12bc74630 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Mon, 4 Mar 2024 01:29:57 -0500 Subject: [PATCH 2/2] Delete 2nd instance of ignored-globals.txt --- Tools/c-analyzer/README | 1 - 1 file changed, 1 deletion(-) diff --git a/Tools/c-analyzer/README b/Tools/c-analyzer/README index 195bac8f2b6eb6..41ea13280347a7 100644 --- a/Tools/c-analyzer/README +++ b/Tools/c-analyzer/README @@ -41,4 +41,3 @@ You can also use the more generic tool: If it reports any globals then they should be resolved. If the globals are runtime state then they should be folded into _PyRuntimeState. -Otherwise they should be added to ignored-globals.txt.