From ee80850f2b74fa1850bfc694a1e67ac02e934ded Mon Sep 17 00:00:00 2001 From: sobolevn Date: Tue, 19 Mar 2024 13:47:44 +0300 Subject: [PATCH 1/3] gh-116991: Improve `pygen --help` for `python` subparser --- Tools/peg_generator/pegen/__main__.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Tools/peg_generator/pegen/__main__.py b/Tools/peg_generator/pegen/__main__.py index 262c8a6db68f6e..9b8dcf7abef017 100755 --- a/Tools/peg_generator/pegen/__main__.py +++ b/Tools/peg_generator/pegen/__main__.py @@ -107,7 +107,13 @@ def generate_python_code( help="Suppress code emission for rule actions", ) -python_parser = subparsers.add_parser("python", help="Generate Python code") +python_parser = subparsers.add_parser( + "python", + help=( + "Generate Python code, needs grammar definition with Python actions, " + "see `we-like-parsers/pegen`" + ) +) python_parser.set_defaults(func=generate_python_code) python_parser.add_argument("grammar_filename", help="Grammar description") python_parser.add_argument( From a67790b0a8e906762c848bc75b9d4192103fc0d3 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Tue, 19 Mar 2024 17:07:44 +0300 Subject: [PATCH 2/3] Update __main__.py --- Tools/peg_generator/pegen/__main__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tools/peg_generator/pegen/__main__.py b/Tools/peg_generator/pegen/__main__.py index 9b8dcf7abef017..a26126b3142d9a 100755 --- a/Tools/peg_generator/pegen/__main__.py +++ b/Tools/peg_generator/pegen/__main__.py @@ -111,7 +111,7 @@ def generate_python_code( "python", help=( "Generate Python code, needs grammar definition with Python actions, " - "see `we-like-parsers/pegen`" + "see `we-like-parsers/pegen`, start with `data/python.gram`" ) ) python_parser.set_defaults(func=generate_python_code) From 4dd52c40dedaee0ed5fe866612ba5885d7946726 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 20 Mar 2024 13:35:23 +0300 Subject: [PATCH 3/3] Address review --- Tools/peg_generator/pegen/__main__.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Tools/peg_generator/pegen/__main__.py b/Tools/peg_generator/pegen/__main__.py index 9b8dcf7abef017..0b0b4b291c2b0e 100755 --- a/Tools/peg_generator/pegen/__main__.py +++ b/Tools/peg_generator/pegen/__main__.py @@ -109,10 +109,7 @@ def generate_python_code( python_parser = subparsers.add_parser( "python", - help=( - "Generate Python code, needs grammar definition with Python actions, " - "see `we-like-parsers/pegen`" - ) + help="Generate Python code, needs grammar definition with Python actions", ) python_parser.set_defaults(func=generate_python_code) python_parser.add_argument("grammar_filename", help="Grammar description")