gh-118418: Deprecate failing to pass a value to the *type_params* parameter of some private typing APIs
#118695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s* parameter of some private `typing` APIs
hugovk
approved these changes
May 7, 2024
sobolevn
approved these changes
May 7, 2024
Member
Author
|
Thanks both for the reviews! |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…s* parameter of some private `typing` APIs (python#118695)
|
Should this be backported to 3.12? |
Member
|
No, we don't backport deprecations. |
Member
Author
No, we shouldn't introduce new deprecation warnings in patch releases. Lots of projects use |
1 task
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are undocumented, private functions, but there's unfortunately widespread usage of them in third-party libraries. Even if we provide a new public API for people to use in Python 3.14, it will take a while for third-party libraries to migrate to the new API. In the meantime, they may get incorrect behaviour if they fail to pass in a value to the type_params parameter. So let's warn them about that.
Closes #118418