Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules (GH-9047) #11921

Merged
merged 1 commit into from Feb 18, 2019

Conversation

@miss-islington
Copy link

commented Feb 18, 2019

Fix C implementation of pickle.loads to use importlib's locking mechanisms, and thereby avoid using partially-loaded modules.
(cherry picked from commit 4371c0a)

Co-authored-by: tjb900 ozburgess@gmail.com

https://bugs.python.org/issue34572

…ving from sys.modules (GH-9047)

Fix C implementation of pickle.loads to use importlib's locking mechanisms, and thereby avoid using partially-loaded modules.
(cherry picked from commit 4371c0a)

Co-authored-by: tjb900 <ozburgess@gmail.com>
@miss-islington

This comment has been minimized.

Copy link
Author

commented Feb 18, 2019

@tjb900 and @pitrou: Status check is done, and it's a success .

@pitrou pitrou merged commit 3129432 into python:3.7 Feb 18, 2019
6 checks passed
6 checks passed
Azure Pipelines PR #20190218.37 succeeded
Details
bedevere/issue-number Issue number 34572 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington miss-islington deleted the miss-islington:backport-4371c0a-3.7 branch Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.