gh-120417: Fix "imported but unused" linter warnings #120461
Conversation
Add __all__ to the following modules: collections.abc, importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in subprocess and xml.sax on two lines.
vstinner
requested review from
brettcannon,
ericsnowcurrently,
gpshead,
ncoghlan,
rhettinger and
warsaw
as code owners
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
My only nitpick is to put them in alphabetical order, to make it easier to find an import when scanning the list.
Are you talking about |
|
I updated the PR:
|
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
It is easy to get __all__ de-synchronized with the module content. I think that all changed modules need tests for __all__. See existing tests that use support.check__all__.
Ok, I added tests. |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. I tested that __all__ includes all non-underscored names except module names.
…0461) Add __all__ to the following modules: importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in collections.abc, subprocess and xml.sax. * Sort __all__; remove collections.abc.__all__; remove private names * Add tests
…0461) Add __all__ to the following modules: importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in collections.abc, subprocess and xml.sax. * Sort __all__; remove collections.abc.__all__; remove private names * Add tests
…0461) Add __all__ to the following modules: importlib.machinery, importlib.util and xml.sax. Add also "# noqa: F401" in collections.abc, subprocess and xml.sax. * Sort __all__; remove collections.abc.__all__; remove private names * Add tests
5 participants
Add
__all__to the following modules: collections.abc, importlib.machinery, importlib.util and xml.sax.Add also "# noqa: F401" in subprocess and xml.sax on two lines.