From 0da87ef3c92d52b7a2a271a5d03a82d5511bc412 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 25 Jun 2024 18:53:24 +0200 Subject: [PATCH] gh-120155: Fix Coverity issue in parse_string() (GH-120997) (cherry picked from commit 769aea332940f03c3e5b1ad9badd6635c1ac992a) Co-authored-by: Victor Stinner --- Parser/string_parser.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Parser/string_parser.c b/Parser/string_parser.c index 65c320c2173e92..164f715e153eca 100644 --- a/Parser/string_parser.c +++ b/Parser/string_parser.c @@ -226,9 +226,14 @@ _PyPegen_parse_string(Parser *p, Token *t) PyErr_BadInternalCall(); return NULL; } + /* Skip the leading quote char. */ s++; len = strlen(s); + // gh-120155: 's' contains at least the trailing quote, + // so the code '--len' below is safe. + assert(len >= 1); + if (len > INT_MAX) { PyErr_SetString(PyExc_OverflowError, "string to parse is too long"); return NULL;