Skip to content

Conversation

@ziima
Copy link
Contributor

@ziima ziima commented Jul 13, 2024

@ghost
Copy link

ghost commented Jul 13, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
There are a few things to improve, mostly related to Sphinx and restructured text.

(I didn't test the suggestion.)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@encukou encukou added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 18, 2024
@encukou encukou merged commit 94e6644 into python:main Jul 18, 2024
@miss-islington-app
Copy link

Thanks @ziima for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
…ck (pythonGH-121666)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 18, 2024
…ck (pythonGH-121666)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 18, 2024

GH-121968 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 18, 2024

GH-121969 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 18, 2024
encukou pushed a commit that referenced this pull request Jul 19, 2024
…ock (GH-121666) (GH-121968)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
encukou pushed a commit that referenced this pull request Jul 19, 2024
…ock (GH-121666) (GH-121969)

Fixed at EuroPython 24 sprints.
(cherry picked from commit 94e6644)

Co-authored-by: Vlastimil Zíma <ziima@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants