Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33012: Fix compilation warnings for memoryview.tobytes and _collections._tuplegetter.__reduce__ #12179

Merged
merged 2 commits into from Mar 5, 2019

Conversation

@matrixise
Copy link
Member

matrixise commented Mar 5, 2019

@matrixise

This comment has been minimized.

Copy link
Member Author

matrixise commented Mar 5, 2019

For the reviewer of this PR, I don't know if I need to add a blurb entry because it's just a simple warning for the compiler

@matrixise matrixise requested a review from rhettinger as a code owner Mar 5, 2019
@matrixise matrixise changed the title bpo-36197: Fix a compilation warning for memoryview.tobytes bpo-36197: Fix a compilation warning for memoryview.tobytes and _collections._tuplegetter.__reduce__ Mar 5, 2019
@matrixise matrixise changed the title bpo-36197: Fix a compilation warning for memoryview.tobytes and _collections._tuplegetter.__reduce__ bpo-36197: Fix compilation warnings for memoryview.tobytes and _collections._tuplegetter.__reduce__ Mar 5, 2019
@vstinner vstinner changed the title bpo-36197: Fix compilation warnings for memoryview.tobytes and _collections._tuplegetter.__reduce__ bpo-33012: Fix compilation warnings for memoryview.tobytes and _collections._tuplegetter.__reduce__ Mar 5, 2019
@vstinner vstinner added the skip news label Mar 5, 2019
@vstinner vstinner merged commit 359a2f3 into python:master Mar 5, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20190305.19 succeeded
Details
bedevere/issue-number Issue number 33012 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ma8ma added a commit to ma8ma/cpython that referenced this pull request Apr 7, 2019
…smodule.c (pythonGH-12179)

Cast function pointers to (void(*)(void)) before casting to (PyCFunction)
to make "warning: cast between incompatible function types" false alarm quiet.
arnolddumas added a commit to arnolddumas/cpython that referenced this pull request May 3, 2019
…smodule.c (pythonGH-12179)

Cast function pointers to (void(*)(void)) before casting to (PyCFunction)
to make "warning: cast between incompatible function types" false alarm quiet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.