bpo-36216: Add check for characters in netloc that normalize to separators #12201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
reviewed
Mar 6, 2019
tiran
requested changes
Mar 6, 2019
|
When you're done making the requested changes, leave the comment: |
tiran
approved these changes
Mar 6, 2019
|
sorry, GH didn't refresh. |
|
I'm removing the "needs backport" tags and will create the backports manually. In particular, the docs need to be slightly different for each version. I'll probably also have to come back later and add the CVE reference once we're assigned one (if we want it in there). |
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 7, 2019
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 7, 2019
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 7, 2019
zooba
added a commit
that referenced
this pull request
Mar 7, 2019
zooba
added a commit
that referenced
this pull request
Mar 7, 2019
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 7, 2019
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 7, 2019
larryhastings
pushed a commit
that referenced
this pull request
Mar 11, 2019
larryhastings
pushed a commit
that referenced
this pull request
Mar 11, 2019
ned-deily
pushed a commit
that referenced
this pull request
Mar 12, 2019
mcepl
reviewed
May 28, 2019
| netloc2 = unicodedata.normalize('NFKC', netloc) | ||
| if netloc == netloc2: | ||
| return | ||
| _, _, netloc = netloc.rpartition('@') # anything to the left of '@' is okay |
There was a problem hiding this comment.
@zooba @tiran Could you tell me something about this line (it is now https://github.com/python/cpython/blob/master/Lib/urllib/parse.py#L405)? It seems to me that it exactly makes the first example from https://bugs.python.org/issue36216 fail as before:
>>> u = "https://example.com\uFF03@bing.com"
>>> urlsplit(u).netloc.rpartition("@")[2]
bing.com
mingwandroid
pushed a commit
to mingwandroid/cpython
that referenced
this pull request
Aug 6, 2019
mingwandroid
pushed a commit
to mingwandroid/cpython
that referenced
this pull request
Aug 6, 2019
mingwandroid
pushed a commit
to mingwandroid/cpython
that referenced
this pull request
Aug 9, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36216