New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36234: Add more tests to PosixUidGidTests #12234
Conversation
@pablogsal @giampaolo @tirkarthi @izbyshev: Would you mind to review this change? It might be to factorize these tests, but I chose to basically apply David's patch. I prefer boring regular Python code than overengineered factories. |
See also the simpler patch for Python 2.7: PR #12235. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
test_posix.PosixUidGidTests: * Add tests for invalid uid/gid type (str) * Add UID_OVERFLOW and GID_OVERFLOW constants to replace (1 << 32) Initial patch written by David Malcolm. Co-Authored-By: David Malcolm <dmalcolm@redhat.com>
Oh, I forgot to mention David in the NEWS entry. I modified my PR to add "Initial patch written by David Malcolm." to the NEWS entry. |
Thanks everybody who reviewed this PR for David :-) |
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-12274 is a backport of this pull request to the 3.7 branch. |
test_posix.PosixUidGidTests: * Add tests for invalid uid/gid type (str) * Add UID_OVERFLOW and GID_OVERFLOW constants to replace (1 << 32) Initial patch written by David Malcolm. Co-Authored-By: David Malcolm <dmalcolm@redhat.com> (cherry picked from commit 876e82b) Co-authored-by: Victor Stinner <vstinner@redhat.com>
test_posix.PosixUidGidTests: * Add tests for invalid uid/gid type (str) * Add UID_OVERFLOW and GID_OVERFLOW constants to replace (1 << 32) Initial patch written by David Malcolm. Co-Authored-By: David Malcolm <dmalcolm@redhat.com> (cherry picked from commit 876e82b) Co-authored-by: Victor Stinner <vstinner@redhat.com>
test_posix.PosixUidGidTests:
Initial patch written by David Malcolm.
Co-Authored-By: David Malcolm dmalcolm@redhat.com
https://bugs.python.org/issue36234