Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd explicit check to silence warning on MacOS #12384
+2
−1
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Mar 17, 2019
bedevere-bot
added
the
awaiting review
label
Mar 17, 2019
This comment has been minimized.
This comment has been minimized.
|
I don't see such warning on macOS. |
This comment has been minimized.
This comment has been minimized.
|
Hi @methane, I am using clang version 10.0.0 and I only get the warning when I am not using
|
methane
added
skip issue
skip news
labels
May 3, 2019
methane
merged commit f090019
into
python:master
May 3, 2019
bedevere-bot
removed
the
awaiting review
label
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
remilapeyre commentedMar 17, 2019
skip news
skip bpo