Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36366: Return None on stopping unstarted patch object #12472

Merged
merged 3 commits into from Mar 28, 2019

Conversation

@tirkarthi
Copy link
Member

tirkarthi commented Mar 20, 2019

Return None after calling unittest.mock.patch.object.stop() regardless of whether the object was started. This makes the method idempotent.

https://bugs.python.org/issue36366

@tirkarthi tirkarthi changed the title bpo36366: Return None on stopping unstarted patch object bpo-36366: Return None on stopping unstarted patch object Mar 20, 2019
@cclauss cclauss mentioned this pull request Mar 20, 2019
5 of 9 tasks complete
@eamanu
eamanu approved these changes Mar 20, 2019
Copy link
Member

brettcannon left a comment

Some minor naming and grammar stuff, otherwise LGTM!

Lib/unittest/test/testmock/testpatch.py Outdated Show resolved Hide resolved
Lib/unittest/test/testmock/testpatch.py Outdated Show resolved Hide resolved
Lib/unittest/test/testmock/testpatch.py Outdated Show resolved Hide resolved
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Mar 27, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Co-Authored-By: tirkarthi <tir.karthi@gmail.com>
@tirkarthi tirkarthi closed this Mar 27, 2019
@tirkarthi tirkarthi reopened this Mar 27, 2019
@tirkarthi

This comment has been minimized.

Copy link
Member Author

tirkarthi commented Mar 28, 2019

Travis has some problems https://www.traviscistatus.com

@tirkarthi

This comment has been minimized.

Copy link
Member Author

tirkarthi commented Mar 28, 2019

I have made the requested changes; please review again.

@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Mar 28, 2019

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@miss-islington miss-islington merged commit 02b84cb into python:master Mar 28, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20190327.50 succeeded
Details
bedevere/issue-number Issue number 36366 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tirkarthi

This comment has been minimized.

Copy link
Member Author

tirkarthi commented Mar 29, 2019

Thanks Brett :)

ma8ma added a commit to ma8ma/cpython that referenced this pull request Apr 7, 2019
…2472)

Return None after calling unittest.mock.patch.object.stop() regardless of whether the object was started. This makes the method idempotent.


https://bugs.python.org/issue36366
arnolddumas added a commit to arnolddumas/cpython that referenced this pull request May 3, 2019
…2472)

Return None after calling unittest.mock.patch.object.stop() regardless of whether the object was started. This makes the method idempotent.


https://bugs.python.org/issue36366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.