Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set. #1272

Conversation

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Apr 24, 2017

Apply an alternate patch from bpo-26811.

https://bugs.python.org/issue30156

Apply an alternate patch from bpo-26811.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Apr 24, 2017

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tim-one, @benjaminp and @tiran to be potential reviewers.

Copy link
Member

vstinner left a comment

See discussion on the issue.

@serhiy-storchaka

This comment has been minimized.

Copy link
Member Author

serhiy-storchaka commented Apr 25, 2017

Excuse me, @Haypo, I have not understood what changes did you request.

@vstinner

This comment has been minimized.

Copy link
Member

vstinner commented Apr 25, 2017

"See discussion on the issue." means see my comment on the issue: http://bugs.python.org/issue30156#msg292239 Basically, I asked if the optimization is worth it.

@brettcannon

This comment has been minimized.

Copy link
Member

brettcannon commented Feb 2, 2018

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@vstinner

This comment has been minimized.

Copy link
Member

vstinner commented Oct 1, 2018

I removed the optimization instead: PR #9541.

@vstinner vstinner closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.