Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-31525: Increase minimum sqlite version number check #12923
Conversation
the-knights-who-say-ni
added
the
CLA not signed
label
Apr 23, 2019
This comment has been minimized.
This comment has been minimized.
the-knights-who-say-ni
commented
Apr 23, 2019
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
bedevere-bot
added
the
awaiting review
label
Apr 23, 2019
This comment has been minimized.
This comment has been minimized.
|
CLA signed now. I don't think an issue number or a news entry is necessary... |
This comment has been minimized.
This comment has been minimized.
There is https://bugs.python.org/issue31525 which would be appropriate |
LordAro
changed the title
Increase minimum sqlite version number check
bpo-31525: Increase minimum sqlite version number check
Apr 23, 2019
berkerpeksag
reviewed
Apr 23, 2019
|
I thought we've already updated |
berkerpeksag
added
skip news
needs backport to 3.7
labels
Apr 23, 2019
the-knights-who-say-ni
added
CLA signed
and removed
CLA not signed
labels
Apr 26, 2019
berkerpeksag
approved these changes
Apr 26, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Apr 26, 2019
berkerpeksag
merged commit ad0daf5
into
python:master
Apr 26, 2019
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Apr 26, 2019
|
Thanks @LordAro for the PR, and @berkerpeksag for merging it |
bedevere-bot
removed
the
awaiting merge
label
Apr 26, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Apr 26, 2019
|
GH-12972 is a backport of this pull request to the 3.7 branch. |
bedevere-bot
removed
the
needs backport to 3.7
label
Apr 26, 2019
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Apr 26, 2019
LordAro
deleted the
LordAro:patch-1
branch
Apr 26, 2019
miss-islington
added a commit
that referenced
this pull request
Apr 26, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
LordAro commentedApr 23, 2019
•
edited by bedevere-bot
setup.py checks for a minimum version of sqlite when building the _sqlite3 extension, but it checks for 3.0.8, whereas the extension makes use of
sqlite3_prepare_v2, which was introduced in 3.3.9 - https://sqlite.org/releaselog/3_3_9.htmlThis PR just bumps the required version number, so that possible failures are detected earlier and are more clear
(I know it's still absolutely ancient, but RHEL5...)
https://bugs.python.org/issue31525