Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31525: Increase minimum sqlite version number check #12923

Merged
merged 2 commits into from Apr 26, 2019

Conversation

Projects
None yet
6 participants
@LordAro
Copy link
Contributor

commented Apr 23, 2019

setup.py checks for a minimum version of sqlite when building the _sqlite3 extension, but it checks for 3.0.8, whereas the extension makes use of sqlite3_prepare_v2, which was introduced in 3.3.9 - https://sqlite.org/releaselog/3_3_9.html

This PR just bumps the required version number, so that possible failures are detected earlier and are more clear

(I know it's still absolutely ancient, but RHEL5...)

https://bugs.python.org/issue31525

@the-knights-who-say-ni

This comment has been minimized.

Copy link

commented Apr 23, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@LordAro

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

CLA signed now. I don't think an issue number or a news entry is necessary...

@vstinner

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

CLA signed now. I don't think an issue number

There is https://bugs.python.org/issue31525 which would be appropriate

@LordAro LordAro changed the title Increase minimum sqlite version number check bpo-31525: Increase minimum sqlite version number check Apr 23, 2019

@berkerpeksag
Copy link
Member

left a comment

I thought we've already updated setup.py, but apparently we weren't... Good catch!

@berkerpeksag berkerpeksag merged commit ad0daf5 into python:master Apr 26, 2019

5 checks passed

Azure Pipelines PR #20190423.18 succeeded
Details
bedevere/issue-number Issue number 31525 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Apr 26, 2019

Thanks @LordAro for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@bedevere-bot

This comment has been minimized.

Copy link

commented Apr 26, 2019

GH-12972 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Apr 26, 2019

bpo-31525: Increase minimum sqlite version number check (pythonGH-12923)
(cherry picked from commit ad0daf5)

Co-authored-by: Charles Pigott <charlespigott@googlemail.com>

@LordAro LordAro deleted the LordAro:patch-1 branch Apr 26, 2019

miss-islington added a commit that referenced this pull request Apr 26, 2019

bpo-31525: Increase minimum sqlite version number check (GH-12923)
(cherry picked from commit ad0daf5)

Co-authored-by: Charles Pigott <charlespigott@googlemail.com>
@berkerpeksag

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

Thanks!

arnolddumas added a commit to arnolddumas/cpython that referenced this pull request May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.