Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-26978: Implement pathlib.Path.link_to (Using os.link) #12990
Conversation
nanjekyejoannah
added some commits
Apr 28, 2019
the-knights-who-say-ni
added
the
CLA signed
label
Apr 28, 2019
bedevere-bot
added
the
awaiting review
label
Apr 28, 2019
auvipy
approved these changes
Apr 28, 2019
bedevere-bot
added
awaiting core review
and removed
awaiting review
labels
Apr 28, 2019
This comment has been minimized.
This comment has been minimized.
|
cc @pitrou |
pitrou
requested changes
Apr 29, 2019
|
Thanks for submitting this PR. You'll find some comments below. |
Doc/library/pathlib.rst Outdated
Lib/pathlib.py Outdated
bedevere-bot
removed
the
awaiting core review
label
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Apr 29, 2019
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
bedevere-bot
added
the
awaiting changes
label
Apr 29, 2019
nanjekyejoannah
added some commits
May 4, 2019
This comment has been minimized.
This comment has been minimized.
|
I have made the requested changes; please review again. |
bedevere-bot
removed
the
awaiting changes
label
May 4, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
May 4, 2019
|
Thanks for making the requested changes! @pitrou: please review the changes made to this pull request. |
bedevere-bot
added
the
awaiting change review
label
May 4, 2019
tirkarthi
reviewed
May 4, 2019
Doc/whatsnew/3.8.rst Outdated
nanjekyejoannah
added some commits
May 4, 2019
pitrou
changed the title
bpo-26978: Implement pathlib.Path.link (Using os.link)
bpo-26978: Implement pathlib.Path.link_to (Using os.link)
May 4, 2019
pitrou
approved these changes
May 4, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting change review
labels
May 4, 2019
This comment has been minimized.
This comment has been minimized.
|
Thank you @nanjekyejoannah. I will wait for CI to pass and then merge if green. |
ZackerySpytz
reviewed
May 4, 2019
| @@ -334,6 +334,10 @@ pathlib | |||
| contain characters unrepresentable at the OS level. | |||
| (Contributed by Serhiy Storchaka in :issue:`33721`.) | |||
|
|
|||
| Added :meth:`pathlib.Path.link_to()` which creates a hard link pointing | |||
| to a path. | |||
| (Contributed by Joannah Nanjekye in :issue:`26978`) | |||
This comment has been minimized.
This comment has been minimized.
ZackerySpytz
May 4, 2019
Contributor
| (Contributed by Joannah Nanjekye in :issue:`26978`) | |
| (Contributed by Joannah Nanjekye in :issue:`26978`.) |
pitrou
merged commit 6b5b013
into
python:master
May 4, 2019
5 checks passed
bedevere-bot
removed
the
awaiting merge
label
May 4, 2019
nanjekyejoannah
deleted the
nanjekyejoannah:issue26978
branch
May 4, 2019
ZackerySpytz
reviewed
May 4, 2019
| @@ -0,0 +1,2 @@ | |||
| `pathlib.path.link_to()` is now implemented. It creates a hard link pointing | |||
This comment has been minimized.
This comment has been minimized.
ZackerySpytz
May 4, 2019
Contributor
It should be pathlib.Path.link_to(), not pathlib.path.link_to().
Also, double backqoutes should be used here instead of single backquotes (as per https://devguide.python.org/documenting/#inline-markup). The following could also be used:
:meth:`pathlib.Path.link_to()`
nanjekyejoannah commentedApr 28, 2019
•
edited
I have implemented
pathlib.Path.link_to.https://bugs.python.org/issue26978