Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-34602: Avoid failures setting macOS stack resource limit #13011
Conversation
ned-deily
added
OS-mac
needs backport to 3.7
labels
Apr 29, 2019
the-knights-who-say-ni
added
the
CLA signed
label
Apr 29, 2019
bedevere-bot
added
the
awaiting core review
label
Apr 29, 2019
ned-deily
merged commit 883dfc6
into
python:master
Apr 29, 2019
5 checks passed
bedevere-bot
removed
the
awaiting core review
label
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Apr 29, 2019
|
Thanks @ned-deily for the PR |
ned-deily
deleted the
ned-deily:bpo-34602-macos-stacksize
branch
Apr 29, 2019
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Apr 29, 2019
bedevere-bot
removed
the
needs backport to 3.7
label
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Apr 29, 2019
|
GH-13013 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Apr 29, 2019
ned-deily
added
the
needs backport to 3.6
label
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
Apr 29, 2019
|
Thanks @ned-deily for the PR |
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
Apr 29, 2019
bedevere-bot
removed
the
needs backport to 3.6
label
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Apr 29, 2019
|
GH-13014 is a backport of this pull request to the 3.6 branch. |
ned-deily
added a commit
that referenced
this pull request
Apr 29, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Apr 29, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
Apr 29, 2019
|
ned-deily commentedApr 29, 2019
•
edited by bedevere-bot
Under some conditions the earlier fix for bpo-18075, "Infinite recursion
tests triggering a segfault on Mac OS X", now causes failures on macOS
when attempting to change stack limit with resource.setrlimit
resource.RLIMIT_STACK, like regrtest does when running the test suite.
The reverted change had specified a non-default stack size when linking
the python executable on macOS. As of macOS 10.14.4, the previous
code causes a hard failure when running tests, although similar
failures had been seen under some conditions under some earlier
systems. For now, revert the original change and resume using
the default stack size when linking the interpreter.
https://bugs.python.org/issue34602