Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-14546: Fix the argument handling in Tools/scripts/lll.py #13026
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Apr 30, 2019
bedevere-bot
added
the
awaiting review
label
Apr 30, 2019
auvipy
approved these changes
May 1, 2019
bedevere-bot
added
awaiting core review
and removed
awaiting review
labels
May 1, 2019
serhiy-storchaka
reviewed
May 2, 2019
Lib/test/test_tools/test_lll.py Outdated
Lib/test/test_tools/test_lll.py Outdated
serhiy-storchaka
approved these changes
May 2, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
May 2, 2019
serhiy-storchaka
merged commit c4e78b1
into
python:master
May 2, 2019
5 checks passed
bedevere-bot
removed
the
awaiting merge
label
May 2, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
May 2, 2019
|
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
May 2, 2019
|
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
May 2, 2019
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
May 2, 2019
|
Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it |
bedevere-bot
removed
the
needs backport to 3.7
label
May 2, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
May 2, 2019
|
GH-13060 is a backport of this pull request to the 3.7 branch. |
This comment has been minimized.
This comment has been minimized.
miss-islington
commented
May 2, 2019
|
Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to |
miss-islington
assigned
serhiy-storchaka
May 2, 2019
miss-islington
added a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2019
This comment has been minimized.
This comment has been minimized.
|
Hi, @serhiy-storchaka. I think that GH-13058 should be merged to fix the buildbot failures. In any case, I will manually create the backport to 2.7 with the fix in GH-13058. |
ZackerySpytz
added a commit
to ZackerySpytz/cpython
that referenced
this pull request
May 2, 2019
bedevere-bot
removed
the
needs backport to 2.7
label
May 2, 2019
This comment has been minimized.
This comment has been minimized.
bedevere-bot
commented
May 2, 2019
|
GH-13063 is a backport of this pull request to the 2.7 branch. |
ZackerySpytz commentedApr 30, 2019
•
edited by bedevere-bot
The Tools/scripts/lll.py script was handling only the last argument.
The unit test follows the style of the other unit tests under
Lib/test/test_tools.
https://bugs.python.org/issue14546