Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-36475: Make PyThread_exit_thread with _Py_NO_RETURN #13068
+17
−15
Conversation
vstinner
added
the
skip news
label
May 2, 2019
the-knights-who-say-ni
added
the
CLA signed
label
May 2, 2019
bedevere-bot
added
the
awaiting core review
label
May 2, 2019
vstinner
referenced this pull request
May 2, 2019
Merged
bpo-36475: Finalize PyEval_AcquireLock() and PyEval_AcquireThread() properly #12667
vstinner
requested a review
from
ncoghlan
May 2, 2019
This comment has been minimized.
This comment has been minimized.
|
@ncoghlan @nanjekyejoannah: Would you mind to review this change? It's a follow-up of PR #12667. |
ncoghlan
approved these changes
May 3, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
May 3, 2019
vstinner
merged commit c664b34
into
python:master
May 4, 2019
bedevere-bot
removed
the
awaiting merge
label
May 4, 2019
vstinner
deleted the
vstinner:noreturn
branch
May 4, 2019
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review Nick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vstinner commentedMay 2, 2019
•
edited by bedevere-bot
https://bugs.python.org/issue36475