Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-36719: Fix regrtest MultiprocessThread (GH-13301) #13303

Merged
merged 1 commit into from May 14, 2019

Conversation

@miss-islington
Copy link

miss-islington commented May 14, 2019

MultiprocessThread.kill() now closes stdout and stderr to prevent
popen.communicate() to hang.
(cherry picked from commit c923c34)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue36719

MultiprocessThread.kill() now closes stdout and stderr to prevent
popen.communicate() to hang.
(cherry picked from commit c923c34)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
Copy link
Member

vstinner left a comment

LGTM, good bot.

@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented May 14, 2019

@vstinner: Status check is done, and it's a failure .

2 similar comments
@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented May 14, 2019

@vstinner: Status check is done, and it's a failure .

@miss-islington

This comment has been minimized.

Copy link
Author

miss-islington commented May 14, 2019

@vstinner: Status check is done, and it's a failure .

@vstinner vstinner merged commit d8e123a into python:3.7 May 14, 2019
5 of 6 checks passed
5 of 6 checks passed
Azure Pipelines PR #20190514.4 failed
Details
bedevere/issue-number Issue number 36719 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington miss-islington deleted the miss-islington:backport-c923c34-3.7 branch May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.