Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36929: Modify io/re tests to allow for missing mod name #13392

Merged
merged 2 commits into from May 21, 2019

Conversation

Projects
None yet
5 participants
@tekknolagi
Copy link
Contributor

commented May 17, 2019

For a vanishingly small number of internal types, CPython sets the
tp_name slot to mod_name.type_name, either in the PyTypeObject or the
PyType_Spec. There are a few minor places where this surfaces:

  • Custom repr functions for those types (some of which ignore the
    tp_name in favor of using a string literal, such as _io.TextIOWrapper)
  • Pickling error messages

The test suite only tests the former. This commit modifies the test
suite to allow Python implementations to omit the module prefix.

https://bugs.python.org/issue36929

bpo-36929: Modify io/re tests to allow for missing mod name
For a vanishingly small number of internal types, CPython sets the
tp_name slot to mod_name.type_name, either in the PyTypeObject or the
PyType_Spec. There are a few minor places where this surfaces:

* Custom repr functions for those types (some of which ignore the
  tp_name in favor of using a string literal, such as _io.TextIOWrapper)
* Pickling error messages

The test suite only tests the former. This commit modifies the test
suite to allow Python implementations to omit the module prefix.

https://bugs.python.org/issue36929
@DinoV

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Tested on Mac OS/X, test changes look good, some lines >80 got a little longer, but they're consistent with some other long lines in the same file, and there's no great way to split them. This should make the test suite more flexible for other Python implementations while still testing the things that matter.

@DinoV DinoV self-assigned this May 20, 2019

@DinoV

DinoV approved these changes May 20, 2019

@DinoV DinoV merged commit ccb7ca7 into python:master May 21, 2019

5 checks passed

Azure Pipelines PR #20190520.60 succeeded
Details
bedevere/issue-number Issue number 36929 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented May 21, 2019

@DinoV: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

This comment has been minimized.

Copy link

commented May 21, 2019

Thanks @tekknolagi for the PR, and @DinoV for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

commented May 21, 2019

GH-13466 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request May 21, 2019

bpo-36929: Modify io/re tests to allow for missing mod name (pythonGH…
…-13392)

* bpo-36929: Modify io/re tests to allow for missing mod name

For a vanishingly small number of internal types, CPython sets the
tp_name slot to mod_name.type_name, either in the PyTypeObject or the
PyType_Spec. There are a few minor places where this surfaces:

* Custom repr functions for those types (some of which ignore the
  tp_name in favor of using a string literal, such as _io.TextIOWrapper)
* Pickling error messages

The test suite only tests the former. This commit modifies the test
suite to allow Python implementations to omit the module prefix.

https://bugs.python.org/issue36929
(cherry picked from commit ccb7ca7)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>

miss-islington added a commit that referenced this pull request May 21, 2019

bpo-36929: Modify io/re tests to allow for missing mod name (GH-13392)
* bpo-36929: Modify io/re tests to allow for missing mod name

For a vanishingly small number of internal types, CPython sets the
tp_name slot to mod_name.type_name, either in the PyTypeObject or the
PyType_Spec. There are a few minor places where this surfaces:

* Custom repr functions for those types (some of which ignore the
  tp_name in favor of using a string literal, such as _io.TextIOWrapper)
* Pickling error messages

The test suite only tests the former. This commit modifies the test
suite to allow Python implementations to omit the module prefix.

https://bugs.python.org/issue36929
(cherry picked from commit ccb7ca7)

Co-authored-by: Max Bernstein <tekknolagi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.