Skip to content

bpo-36853: Fix suspicious.py to actually print the unused rules #13579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2019
Merged

bpo-36853: Fix suspicious.py to actually print the unused rules #13579

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72caf77
Fix suspicious.py to actually print the unused rules
asottile May 26, 2019
f8391f7
Fix the other `self.warn` calls
asottile May 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions Doc/tools/extensions/suspicious.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,10 +115,12 @@ def write_doc(self, docname, doctree):
def finish(self):
unused_rules = [rule for rule in self.rules if not rule.used]
if unused_rules:
self.logger.warn('Found %s/%s unused rules:' %
(len(unused_rules), len(self.rules)))
for rule in unused_rules:
self.logger.info(repr(rule))
self.logger.warning(
'Found %s/%s unused rules: %s' % (
len(unused_rules), len(self.rules),
''.join(repr(rule) for rule in unused_rules),
)
)
return

def check_issue(self, line, lineno, issue):
Expand Down Expand Up @@ -151,14 +153,15 @@ def report_issue(self, text, lineno, issue):
self.any_issue = True
self.write_log_entry(lineno, issue, text)
if py3:
self.logger.warn('[%s:%d] "%s" found in "%-.120s"' %
(self.docname, lineno, issue, text))
self.logger.warning('[%s:%d] "%s" found in "%-.120s"' %
(self.docname, lineno, issue, text))
else:
self.logger.warn('[%s:%d] "%s" found in "%-.120s"' % (
self.docname.encode(sys.getdefaultencoding(),'replace'),
lineno,
issue.encode(sys.getdefaultencoding(),'replace'),
text.strip().encode(sys.getdefaultencoding(),'replace')))
self.logger.warning(
'[%s:%d] "%s" found in "%-.120s"' % (
self.docname.encode(sys.getdefaultencoding(),'replace'),
lineno,
issue.encode(sys.getdefaultencoding(),'replace'),
text.strip().encode(sys.getdefaultencoding(),'replace')))
self.app.statuscode = 1

def write_log_entry(self, lineno, issue, text):
Expand Down