[2.7] bpo-30223: Add Lib/test/__main__.py. #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To unify running tests in Python 2.7 and Python 3, the test package can be run as a script. This is equivalent to running the test.regrtest module as a script.
vstinner
requested changes
May 2, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I tested your change, and it doesn't work.
Did you forget to include Lib/test/main.py as mentioned in the commit title?
|
|
||
| The :mod:`test.test_support` module has been renamed to :mod:`test.support` | ||
| in Python 3.x and 2.7.13. The name ``test.test_support`` has been retained | ||
| in Python 3.x and 2.7.14. The name ``test.test_support`` has been retained |
Member
There was a problem hiding this comment.
This change is ok: the commit a694e09 is not part of Python 2.7.13.
Member
|
(Maybe it's time to backport test_regrtest.py :-) It's up to you, just add main.py and it will be ok.) |
vstinner
approved these changes
May 2, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
"Add missed Lib/test/main.py."
Ah, it's now better: it works ;-)
Member
Author
test_regrtest.py mainly tests regrtest._parse_args() which doesn't exist in 2.7. It was added when regrtest was switched from using getopt to using argparse. This was a large change. |
Member
|
test_regrtest.py mainly tests regrtest._parse_args() which doesn't exist in 2.7.
test_regrtest contains many tests which make sense for Python 2.7, but it was just an idea and I don't think that it matters. regrtest isn't going to change deeply in Python 2.7.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To unify running tests in Python 2.7 and Python 3, the test
package can be run as a script. This is equivalent to running the
test.regrtest module as a script.