From e73853e010a1b71ae4cc4e904886074d6bf0ff0d Mon Sep 17 00:00:00 2001 From: Sebastien Williams-Wynn Date: Sat, 2 Aug 2025 22:47:05 +0100 Subject: [PATCH 1/4] Disambiguate issue number --- Lib/os.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/os.py b/Lib/os.py index 12926c832f5ba5..fe494e70524f45 100644 --- a/Lib/os.py +++ b/Lib/os.py @@ -491,7 +491,7 @@ def fwalk(top=".", topdown=True, onerror=None, *, follow_symlinks=False, dir_fd= def _fwalk(stack, isbytes, topdown, onerror, follow_symlinks): # Note: This uses O(depth of the directory tree) file descriptors: if # necessary, it can be adapted to only require O(1) FDs, see issue - # #13734. + # bpo-13734 (gh-57943). action, value = stack.pop() if action == _fwalk_close: From 27d7e311b2b587f595b1e2a2ed013679780611e8 Mon Sep 17 00:00:00 2001 From: Sebastien Williams-Wynn Date: Sat, 2 Aug 2025 23:22:51 +0100 Subject: [PATCH 2/4] Response to review suggestion --- Lib/os.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/os.py b/Lib/os.py index fe494e70524f45..b4ba2380cfd6fa 100644 --- a/Lib/os.py +++ b/Lib/os.py @@ -491,7 +491,7 @@ def fwalk(top=".", topdown=True, onerror=None, *, follow_symlinks=False, dir_fd= def _fwalk(stack, isbytes, topdown, onerror, follow_symlinks): # Note: This uses O(depth of the directory tree) file descriptors: if # necessary, it can be adapted to only require O(1) FDs, see issue - # bpo-13734 (gh-57943). + # https://github.com/python/cpython/issues/57943 action, value = stack.pop() if action == _fwalk_close: From 462387685fc0e596700b9d811014baca8df20ab6 Mon Sep 17 00:00:00 2001 From: Sebastien Williams-Wynn Date: Sat, 2 Aug 2025 23:26:47 +0100 Subject: [PATCH 3/4] Follow suggestion --- Lib/os.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/os.py b/Lib/os.py index b4ba2380cfd6fa..42633ac0ca89ab 100644 --- a/Lib/os.py +++ b/Lib/os.py @@ -490,8 +490,8 @@ def fwalk(top=".", topdown=True, onerror=None, *, follow_symlinks=False, dir_fd= def _fwalk(stack, isbytes, topdown, onerror, follow_symlinks): # Note: This uses O(depth of the directory tree) file descriptors: if - # necessary, it can be adapted to only require O(1) FDs, see issue - # https://github.com/python/cpython/issues/57943 + # necessary, it can be adapted to only require O(1) FDs. + # See https://github.com/python/cpython/issues/57943 action, value = stack.pop() if action == _fwalk_close: From 4d75c33632db38536f8e12cf160b586b1c74a914 Mon Sep 17 00:00:00 2001 From: Sebastien Williams-Wynn Date: Sat, 2 Aug 2025 23:30:46 +0100 Subject: [PATCH 4/4] Complete sentence --- Lib/os.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/os.py b/Lib/os.py index 42633ac0ca89ab..77771249967fc7 100644 --- a/Lib/os.py +++ b/Lib/os.py @@ -491,7 +491,7 @@ def fwalk(top=".", topdown=True, onerror=None, *, follow_symlinks=False, dir_fd= def _fwalk(stack, isbytes, topdown, onerror, follow_symlinks): # Note: This uses O(depth of the directory tree) file descriptors: if # necessary, it can be adapted to only require O(1) FDs. - # See https://github.com/python/cpython/issues/57943 + # See https://github.com/python/cpython/issues/57943. action, value = stack.pop() if action == _fwalk_close: