Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings #13758

Merged
merged 1 commit into from Jun 2, 2019

Conversation

@encukou encukou merged commit e584cbf into python:master Jun 2, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20190602.55 succeeded
Details
bedevere/issue-number Issue number 36027 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@encukou encukou deleted the encukou:warning-fix branch Jun 2, 2019
@@ -4243,7 +4243,7 @@ long_invmod(PyLongObject *a, PyLongObject *n)

Py_DECREF(c);
Py_DECREF(n);
if (long_compare(a, _PyLong_One)) {
if (long_compare(a, (PyObject *)_PyLong_One)) {

This comment has been minimized.

Copy link
@encukou

encukou Jun 3, 2019

Author Member

This is wrong, it should be PyLongObject.
#13761 is the proper fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.