From e1e5005c3e8efea3635376f661a3fc5bd51ca97b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Kul=C3=ADk?= Date: Wed, 27 Aug 2025 19:41:14 +0200 Subject: [PATCH] bpo-41839: Fix error checking in sched_get_priority_ functions (GH-22374) (cherry picked from commit bbcb75c986c47887e6c0757e63d59cd7af544f39) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jakub KulĂ­k --- .../Library/2020-09-23-11-54-17.bpo-41839.kU5Ywl.rst | 2 ++ Modules/posixmodule.c | 12 +++++++----- 2 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2020-09-23-11-54-17.bpo-41839.kU5Ywl.rst diff --git a/Misc/NEWS.d/next/Library/2020-09-23-11-54-17.bpo-41839.kU5Ywl.rst b/Misc/NEWS.d/next/Library/2020-09-23-11-54-17.bpo-41839.kU5Ywl.rst new file mode 100644 index 00000000000000..760660408100d5 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2020-09-23-11-54-17.bpo-41839.kU5Ywl.rst @@ -0,0 +1,2 @@ +Allow negative priority values from :func:`os.sched_get_priority_min` and +:func:`os.sched_get_priority_max` functions. diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index 904c2f55bbccca..65339b863bce18 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -8186,10 +8186,10 @@ static PyObject * os_sched_get_priority_max_impl(PyObject *module, int policy) /*[clinic end generated code: output=9e465c6e43130521 input=2097b7998eca6874]*/ { - int max; - - max = sched_get_priority_max(policy); - if (max < 0) + /* make sure that errno is cleared before the call */ + errno = 0; + int max = sched_get_priority_max(policy); + if (max == -1 && errno) return posix_error(); return PyLong_FromLong(max); } @@ -8207,8 +8207,10 @@ static PyObject * os_sched_get_priority_min_impl(PyObject *module, int policy) /*[clinic end generated code: output=7595c1138cc47a6d input=21bc8fa0d70983bf]*/ { + /* make sure that errno is cleared before the call */ + errno = 0; int min = sched_get_priority_min(policy); - if (min < 0) + if (min == -1 && errno) return posix_error(); return PyLong_FromLong(min); }