Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [locks] #13920

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@eamanu
Copy link
Contributor

commented Jun 8, 2019

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py

https://bugs.python.org/issue36373

Automerge-Triggered-By: @asvetlov

Deprecate explicit loop parameter asyncio
This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py
@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

Please don't merge because ./python -Werror -m test -v test_asyncio is fallling

eamanu added 2 commits Jun 10, 2019

@eamanu eamanu requested a review from rhettinger as a code owner Jun 10, 2019

@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@asvetlov I think this PR is ready now

----------------------------------------------------------------------

Ran 2153 tests in 81.037s

OK (skipped=35)
test_asyncio passed in 1 min 21 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 min 21 sec
Tests result: SUCCESS
@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

ping @asvetlov :-)

@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

ping @asvetlov

@asvetlov
Copy link
Contributor

left a comment

LGTM
Sorry for the delay.
Thank for your patience.

@miss-islington miss-islington merged commit 537877d into python:master Sep 10, 2019

5 checks passed

Azure Pipelines PR #20190610.39 succeeded
Details
bedevere/issue-number Issue number 36373 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 10, 2019

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@miss-islington

This comment has been minimized.

Copy link

commented Sep 10, 2019

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

This comment has been minimized.

Copy link

commented Sep 10, 2019

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP…
…Is [locks] (pythonGH-13920)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py

https://bugs.python.org/issue36373
(cherry picked from commit 537877d)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 10, 2019

GH-15835 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 10, 2019
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP…
…Is [locks] (GH-13920)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py

https://bugs.python.org/issue36373
(cherry picked from commit 537877d)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
bpo-36373: Deprecate explicit loop parameter in all public asyncio A…
…PIs [locks] (pythonGH-13920)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py





https://bugs.python.org/issue36373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.