From 053a8c29336a281e1f107783a701c5c5fdc158a5 Mon Sep 17 00:00:00 2001 From: Ho Kim Date: Wed, 24 Sep 2025 12:51:24 +0000 Subject: [PATCH 1/3] fix: add missing `build-details.json` step for building wasm Signed-off-by: Ho Kim --- Makefile.pre.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.pre.in b/Makefile.pre.in index eedccc3ffe6a49..d121bd0958f1af 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -801,10 +801,10 @@ build_all: check-clean-src check-app-store-compliance $(BUILDPYTHON) platform sh .PHONY: build_wasm build_wasm: check-clean-src $(BUILDPYTHON) platform sharedmods \ - python-config checksharedmods + python-config checksharedmods build-details.json .PHONY: build_emscripten -build_emscripten: build_wasm web_example web_example_pyrepl_jspi +build_emscripten: build_wasm build-details.json web_example web_example_pyrepl_jspi # Check that the source is clean when building out of source. .PHONY: check-clean-src From 4c3bcf2d7efc76cddccf6dfc7046c4a7af254cbf Mon Sep 17 00:00:00 2001 From: Ho Kim Date: Wed, 24 Sep 2025 14:01:03 +0000 Subject: [PATCH 2/3] gh-138489: Add missing build-details.json step for building wasm Signed-off-by: Ho Kim --- .../Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst diff --git a/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst b/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst new file mode 100644 index 00000000000000..b11098a3f87953 --- /dev/null +++ b/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst @@ -0,0 +1,6 @@ +When cross-compiling for WASI by ``build_wasm`` or ``build_emscripten``, the +``build-details.json`` step is now included in the build process, just like +with native builds. + +This fixes the ``libinstall`` task which requires the ``build-details.json`` +file during the process. From 6bbad6d6cc21d52808b7708a9e9ced747c8c40a0 Mon Sep 17 00:00:00 2001 From: Ho Kim Date: Wed, 24 Sep 2025 23:13:02 +0900 Subject: [PATCH 3/3] Update Makefile.pre.in Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --- Makefile.pre.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.pre.in b/Makefile.pre.in index d121bd0958f1af..24a328d58c2985 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -804,7 +804,7 @@ build_wasm: check-clean-src $(BUILDPYTHON) platform sharedmods \ python-config checksharedmods build-details.json .PHONY: build_emscripten -build_emscripten: build_wasm build-details.json web_example web_example_pyrepl_jspi +build_emscripten: build_wasm web_example web_example_pyrepl_jspi # Check that the source is clean when building out of source. .PHONY: check-clean-src