Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue] #13950

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Jun 10, 2019

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373

Automerge-Triggered-By: @asvetlov

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py
@eamanu
Copy link
Contributor Author

eamanu commented Jun 10, 2019

This PR depends of the tests fixed on #13920. #13920 should be merged first.

@eamanu
Copy link
Contributor Author

eamanu commented Jun 10, 2019

CC: @asvetlov

@MakDon
Copy link
Contributor

MakDon commented Jun 13, 2019

LGTM. :D

@eamanu
Copy link
Contributor Author

eamanu commented Jun 22, 2019

ping @asvetlov :-)

@eamanu
Copy link
Contributor Author

eamanu commented Aug 5, 2019

ping @asvetlov

Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 9008be3 into python:master Sep 10, 2019
@miss-islington
Copy link
Contributor

@eamanu: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
(cherry picked from commit 9008be3)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
@bedevere-bot
Copy link

GH-15841 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 10, 2019
miss-islington added a commit that referenced this pull request Sep 10, 2019
…Is [queue] (GH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
(cherry picked from commit 9008be3)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
tirkarthi pushed a commit to tirkarthi/cpython that referenced this pull request Sep 27, 2019
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py





https://bugs.python.org/issue36373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants