Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue] #13950

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@eamanu
Copy link
Contributor

commented Jun 10, 2019

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373

Automerge-Triggered-By: @asvetlov

Deprecate explicit loop in all public asyncio
This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py
@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

This PR depends of the tests fixed on #13920. #13920 should be merged first.

@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

CC: @asvetlov

@MakDon
MakDon approved these changes Jun 13, 2019
@MakDon

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

LGTM. :D

@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

ping @asvetlov :-)

@eamanu

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

ping @asvetlov

@asvetlov
Copy link
Contributor

left a comment

LGTM. Thanks

@miss-islington

This comment has been minimized.

Copy link

commented Sep 10, 2019

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 9008be3 into python:master Sep 10, 2019

5 checks passed

Azure Pipelines PR #20190610.37 succeeded
Details
bedevere/issue-number Issue number 36373 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 10, 2019

@eamanu: Status check is done, and it's a success .

@miss-islington

This comment has been minimized.

Copy link

commented Sep 10, 2019

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Sep 10, 2019

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP…
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
(cherry picked from commit 9008be3)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 10, 2019

GH-15841 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 10, 2019
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP…
…Is [queue] (GH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
(cherry picked from commit 9008be3)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP…
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py





https://bugs.python.org/issue36373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.