From 7f8ddf01d1f8500c64c1304dd57e432c8de7da7f Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 11 Jun 2019 03:02:39 +0200 Subject: [PATCH] bpo-36918, test_urllib: Silence FakeHTTPConnection destructor errors Implement FakeHTTPConnection.close() to silence destructor errors. Co-Authored-By: Xtreak --- Lib/test/test_urllib.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py index f9b2799d25bfd0..8afceacae68b71 100644 --- a/Lib/test/test_urllib.py +++ b/Lib/test/test_urllib.py @@ -90,6 +90,12 @@ class FakeHTTPConnection(http.client.HTTPConnection): def connect(self): self.sock = FakeSocket(self.fakedata) type(self).fakesock = self.sock + + def close(self): + # bpo-36918: Don't bother to track exactly I/O references + # of FakeSocket: do nothing to silence finalizer exception + pass + FakeHTTPConnection.fakedata = fakedata return FakeHTTPConnection