From 8cbc4bbda9e38c3eb6f748b1b147ea03ef9db5c2 Mon Sep 17 00:00:00 2001 From: Ho Kim Date: Sat, 4 Oct 2025 22:26:20 +0900 Subject: [PATCH] gh-138489: Add missing `build-details.json` step for building wasm (GH-139302) * fix: add missing `build-details.json` step for building wasm Signed-off-by: Ho Kim * gh-138489: Add missing build-details.json step for building wasm Signed-off-by: Ho Kim * Update Makefile.pre.in Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --------- (cherry picked from commit db53ca30d761abba525bc8e47b16920b1fc43a83) Co-authored-by: Ho Kim Signed-off-by: Ho Kim Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> --- Makefile.pre.in | 2 +- .../Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst diff --git a/Makefile.pre.in b/Makefile.pre.in index ba039794c88b01..5fcd9f509dee11 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -801,7 +801,7 @@ build_all: check-clean-src check-app-store-compliance $(BUILDPYTHON) platform sh .PHONY: build_wasm build_wasm: check-clean-src $(BUILDPYTHON) platform sharedmods \ - python-config checksharedmods + python-config checksharedmods build-details.json .PHONY: build_emscripten build_emscripten: build_wasm web_example web_example_pyrepl_jspi diff --git a/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst b/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst new file mode 100644 index 00000000000000..b11098a3f87953 --- /dev/null +++ b/Misc/NEWS.d/next/Build/2025-09-24-13-59-26.gh-issue-138489.1AcuZM.rst @@ -0,0 +1,6 @@ +When cross-compiling for WASI by ``build_wasm`` or ``build_emscripten``, the +``build-details.json`` step is now included in the build process, just like +with native builds. + +This fixes the ``libinstall`` task which requires the ``build-details.json`` +file during the process.