Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35766: Whats new in the ast and typing modules #13984

Merged
merged 2 commits into from Jun 11, 2019

Conversation

Projects
None yet
6 participants
@gvanrossum
Copy link
Member

commented Jun 11, 2019

Lumping these together because they both come from the static type checking world.

https://bugs.python.org/issue35766

@vstinner
Copy link
Member

left a comment

LGTM.

I looked for "3.8" in https://docs.python.org/dev/library/ast.html and https://docs.python.org/dev/library/typing.html and it seems like all changes are documented.

@ilevkivskyi
Copy link
Contributor

left a comment

Looks great!

@gvanrossum gvanrossum merged commit 9b33ce4 into python:master Jun 11, 2019

5 checks passed

Azure Pipelines PR #20190611.63 succeeded
Details
bedevere/issue-number Issue number 35766 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

This comment has been minimized.

Copy link

commented Jun 11, 2019

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@gvanrossum gvanrossum deleted the gvanrossum:whats-new-ast-typing branch Jun 11, 2019

@bedevere-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

GH-13987 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jun 11, 2019

bpo-35766: What's new in the ast and typing modules (pythonGH-13984)
(cherry picked from commit 9b33ce4)

Co-authored-by: Guido van Rossum <guido@python.org>

miss-islington added a commit that referenced this pull request Jun 11, 2019

bpo-35766: What's new in the ast and typing modules (GH-13984)
(cherry picked from commit 9b33ce4)

Co-authored-by: Guido van Rossum <guido@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.