-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-140766: add enum.show_flag_values and enum.bin to enum.__all__
#140765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
enum.show_flag_values to enum.__all__enum.show_flag_values to enum.__all__
|
It appears that Line 5327 in c74793c
https://docs.python.org/3/library/enum.html#enum.show_flag_values |
|
Hmm. That seems odd to me, but I'll defer to @ethanfurman here as the enum maintainer :-) |
|
Let's go ahead and put both in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add both bin and show_flag_values to __all__.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
|
|
enum.show_flag_values to enum.__all__enum.show_flag_values and enum.bin to enum.__all__
Misc/NEWS.d/next/Library/2025-10-29-16-53-00.gh-issue-140766.CNagKF.rst
Outdated
Show resolved
Hide resolved
…NagKF.rst Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @guoci, I'm happy to commit as-is, or you can add bin to the docs -- whatever you are comfortable with.
|
@ethanfurman Thanks, I will add in the docs sometime later, you can commit now. |
@AlexWaygood
Fix as suggested in:
python/typeshed#14938 (comment)
enum.show_flag_valuesinenum.__all__#140766