From 11413790ab6be085c5d9b72554a05375d70f338a Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 31 Oct 2025 16:25:36 +0100 Subject: [PATCH 1/4] Remove __class_getitem__ from mailbox._ProxyFile --- Lib/mailbox.py | 2 -- .../next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst diff --git a/Lib/mailbox.py b/Lib/mailbox.py index b00d9e8634c785..4a44642765cc9a 100644 --- a/Lib/mailbox.py +++ b/Lib/mailbox.py @@ -2090,8 +2090,6 @@ def closed(self): return False return self._file.closed - __class_getitem__ = classmethod(GenericAlias) - class _PartialFile(_ProxyFile): """A read-only wrapper of part of a file.""" diff --git a/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst b/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst new file mode 100644 index 00000000000000..b2ab5e8a7ddbe0 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst @@ -0,0 +1,2 @@ +The internal class :class:`mailbox._ProxyFile` is no longer marked as +generic. From 8516faf07c045b6c78b4a3185f7eb42abf8d2fca Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 31 Oct 2025 16:33:33 +0100 Subject: [PATCH 2/4] Remove :class: marker in NEWS file --- .../next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst b/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst index b2ab5e8a7ddbe0..4d1caac629988d 100644 --- a/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst +++ b/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst @@ -1,2 +1,2 @@ -The internal class :class:`mailbox._ProxyFile` is no longer marked as +The internal class ``mailbox._ProxyFile`` is no longer marked as generic. From 34fbf56a4c120aac176a620da5045b8dfed0fc3a Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 31 Oct 2025 16:49:36 +0100 Subject: [PATCH 3/4] Remove _PartialFile from test_genericalias --- Lib/test/test_genericalias.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_genericalias.py b/Lib/test/test_genericalias.py index 4e08adaca05cdd..9df9296e26ad5c 100644 --- a/Lib/test/test_genericalias.py +++ b/Lib/test/test_genericalias.py @@ -17,7 +17,7 @@ from functools import partial, partialmethod, cached_property from graphlib import TopologicalSorter from logging import LoggerAdapter, StreamHandler -from mailbox import Mailbox, _PartialFile +from mailbox import Mailbox try: import ctypes except ImportError: @@ -117,7 +117,7 @@ class BaseTest(unittest.TestCase): Iterable, Iterator, Reversible, Container, Collection, - Mailbox, _PartialFile, + Mailbox, ContextVar, Token, Field, Set, MutableSet, From d8f279fad43d17b947504dec2470b8ff8ac7d414 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Sat, 1 Nov 2025 14:28:35 +0100 Subject: [PATCH 4/4] Update NEWS wording Co-authored-by: Emma Smith --- .../Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst b/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst index 4d1caac629988d..090f39c6e25fdf 100644 --- a/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst +++ b/Misc/NEWS.d/next/Library/2025-10-31-16-25-13.gh-issue-140808.XBiQ4j.rst @@ -1,2 +1 @@ -The internal class ``mailbox._ProxyFile`` is no longer marked as -generic. +The internal class ``mailbox._ProxyFile`` is no longer a parameterized generic.