gh-100218: correctly set errno when socket.if_{nametoindex,indextoname} raise OSError
#140905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
added
needs backport to 3.13
Member
Author
|
I used https://man.cx/if_nametoindex#heading5 for the default errors of each function. |
picnixz
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 551a199 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140905%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
Author
|
All failures are urllib2net failures that already track: #140748. |
efimov-mikhail
approved these changes
Nov 9, 2025
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2025
…ndextoname}` raise `OSError` (pythonGH-140905) Previously, socket.if_nametoindex() and socket.if_indextoname() could raise an `OSError` with a `None` errno. Now, the errno from libc is propagated. (cherry picked from commit 3ce2d57) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-141284 is a backport of this pull request to the 3.14 branch. |
|
Sorry, @picnixz, I could not cleanly backport this to |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Nov 9, 2025
…index,indextoname}` raise `OSError` (pythonGH-140905) Previously, socket.if_nametoindex() and socket.if_indextoname() could raise an `OSError` with a `None` errno. Now, the errno from libc is propagated. (cherry picked from commit 3ce2d57) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-141285 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
that referenced
this pull request
Nov 9, 2025
…indextoname}` raise `OSError` (GH-140905) (#141284) gh-100218: correctly set `errno` when `socket.if_{nametoindex,indextoname}` raise `OSError` (GH-140905) Previously, socket.if_nametoindex() and socket.if_indextoname() could raise an `OSError` with a `None` errno. Now, the errno from libc is propagated. (cherry picked from commit 3ce2d57) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
socket.if_nametoindex('no-such-iface')raisesOSError()without settingerrno#100218