gh-141042: fix sNaN's packing for mixed floating-point formats #141107
Conversation
skirpichev
changed the title
|
CC @vstinner |
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Let's check on buildbots.
vstinner
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @vstinner for commit 3f6b0ef 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141107%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
|
We have no RISC-V buildbot, maybe @stefanor can assist with testing? (Though, I don't expect surprises here.) |
|
failures:
|
This comment was marked as resolved.
This comment was marked as resolved.
|
FWIW, this branch passes |
|
@stefanor, thanks. I think now it should be ok - I forgot to move around code, that "fix" NaN's type. |
|
Yes, that now passes on riscv64. |
|
Thanks @skirpichev for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…ythonGH-141107) (cherry picked from commit 23d85a2) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
|
GH-141459 is a backport of this pull request to the 3.14 branch. |
|
Merged. Thanks for the fix. |
…GH-141107) (#141459) gh-141042: fix sNaN's packing for mixed floating-point formats (GH-141107) (cherry picked from commit 23d85a2) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
4 participants
Uh oh!
There was an error while loading. Please reload this page.