-
-
Notifications
You must be signed in to change notification settings - Fork 33.4k
gh-141335: Deque as a Growable Ring Buffer #141337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
matthiasgoergens
wants to merge
11
commits into
python:main
from
matthiasgoergens:growable-ring-buffer
+1,203
−904
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
8aeb1d7
Deque as growable ring buffer
matthiasgoergens 8c9f61a
Apply suggestion from @Copilot
matthiasgoergens 26f8e60
Minimise diff
matthiasgoergens 117077d
Merge remote-tracking branch 'matthias/growable-ring-buffer' into gro…
matthiasgoergens 7795fe5
Minimise diff
matthiasgoergens cd926b5
Fix bug
matthiasgoergens 3e2b962
Merge remote-tracking branch 'origin/main' into growable-ring-buffer
matthiasgoergens 99784a8
Placate compiler
matthiasgoergens 8fb28fe
Fix Windows build
matthiasgoergens 3e7628d
Maxlen
matthiasgoergens d07a9c2
Merge branch 'main' into growable-ring-buffer
matthiasgoergens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also leave the behaviour the same as before (raise
OverflowError), or fix it to be in line with what eg slicing for lists does (which handles huge numbers gracefully.)